/dev/null
Sign in

Commit

503c794

Raphael Stolt@raphaelstolt
Anyone using https://github.com/ramsey/conventional-commits in a 🐘 project? Just asking, because I’m considering it for my next project.
GitHubGitHub - ramsey/conventional-commits: :yo_yo: A PHP library for creating and validating commit messages according to the Conventional Commits specification. Includes a CaptainHook plugin!:yo_yo: A PHP library for creating and validating commit messages according to the Conventional Commits specification. Includes a CaptainHook plugin! - ramsey/conventional-commits
Clemens Krack@ckrack
No, but commitlint wrapped around gh api calls in an action. I enforce it in CI and it includes PR title (and commits). In my eyes that’s not a thing to enforce locally in hooks. I want to allow quick „wip“ or fire in the building pushes, but they need to be dealt with later…
Younes@younes-io
a wip can be done in a throwaway worktree.. but not in the main branch; why would a wip commit be merged to the main branch? unless you rewrite the git history and you do some sort of clean up your commits could become the changelog so they need to be clear
Clemens Krack@ckrack
That’s not what I meant. Nothing ever goes to main without a PR. I guard that in CI, but I’m against preventing a commit/push to a dev branch.
Clemens Krack@ckrack
Yes, but not when there’s a fire in the building. There is another reason: Some folks like to do fixup commits and push those, so it’s visible what was changed after a review. Those are also not valid and will be squashed into their original commits later before a merge.

commit 503c794