replying to @dtinth-bot
Please make a PR and watch it. Once you think it's ready for review, please put it out of draft.
Commit
713dfff
@dtinth PR #36 is ready for review: CI green (both builds with smoke tests, setup wizard). https://github.com/dtinth/agent-env/pull/36
GitHubConfigurator: Preact stepper, Import button, answers inside compose.yaml by dtinth-claw[bot] · Pull Request #36 · dtinth/agent-envThe web configurator, redone as a Preact stepper in the dt.in.th design system that claw uses (dark only), and the setup answers moved into compose.yaml. Picked from three prototypes discussed on d...
Done in 4a1f170: the summary values are now muted body text, the same as Opens at. Pushed to #36.
No need for the text below the heading ("Answers in…"), please remove it.
Removed in 620bf20: the header is just the title and Import now. Pushed to #36.
Please watch and address the review comments.
Both fixed in 93ef0b7. The missing-secrets notice now stays until you import the .env, re-roll, or click "use the new ones". Importing only a .env keeps your answers. Checked both in the browser.
Thanks - please merge to main when green.
CI is green on 93ef0b7, but my session's permission check blocked the merge as unreviewed. Could you press Rebase and merge on #36, or allow merges for my session?
Permission granted
@dtinth Merged to main (rebase, b52508c): https://github.com/dtinth/agent-env/pull/36
GitHubConfigurator: Preact stepper, Import button, answers inside compose.yaml by dtinth-claw[bot] · Pull Request #36 · dtinth/agent-envThe web configurator, redone as a Preact stepper in the dt.in.th design system that claw uses (dark only), and the setup answers moved into compose.yaml. Picked from three prototypes discussed on d...
What is
name: agent-env in the compose file? Would this prevent running multiple envs on a single machine?It's the Compose project name, so yes: a second deploy with the same name replaces the first's containers and shares its volumes, even from another directory. Dropping the line makes the folder name the default. Ports must still differ. Want that?
Yes. I think we should allow configuring the environment name. This will impact the hostname of the container too so when not using Tailscale the shell prompt looks nice. Default
agent-env.https://github.com/dtinth/agent-env/pull/37 The name is asked first, defaults to agent-env, and sets both the Compose project and the hostname (under Tailscale the sidecar's hostname applies instead). CI is running.
GitHubConfigurator: name the environment (Compose project and hostname) by dtinth-claw[bot] · Pull Request #37 · dtinth/agent-envEvery generated compose.yaml had name: agent-env, so a second deployment on the same host was the same Compose project as the first. docker compose up took over its containers and shared its volume...
Why https port detault to 8443? Can it be 443 instead? Also for public domain, is it possible to make it support shortlived Let's Encrypt IP certs? Alternatives are nip and sslip.
IP certs: yes. Caddy gets one with the IP as the site address and profile shortlived; I still have to check our image has that fix. Google sign-in may refuse an IP redirect URI. sslip.io/nip.io names already work. Put 443 + IP mode in #37, or a new PR?
sslip.ioWelcome to nip.io / sslip.ionip.io / sslip.io
Put in same PR pls.
@dtinth Pushed to https://github.com/dtinth/agent-env/pull/37: None mode (expose only), IPv4 certs via profile shortlived (Google refused for an IP, sslip.io suggested), 443 default. CI running.
GitHubConfigurator: name the environment (Compose project and hostname) by dtinth-claw[bot] · Pull Request #37 · dtinth/agent-envEvery generated compose.yaml had name: agent-env, so a second deployment on the same host was the same Compose project as the first. docker compose up took over its containers and shared its volume...
I want to ask for a new feature in the configurator: Allow specifying memory limit. Not sure how to deal with swap too. And maybe CPU limits too. Also need advice if disk quota or limit is possible and what are the possible ways to do it. These are advanced optional features tho.
commit 713dfff
On it, in #37 as optional advanced answers: memory (mem_limit), swap (memswap_limit: none, Docker's default, or an amount) and CPUs (cpus). Disk advice to follow; short version: Compose can't cap volumes, the host filesystem has to.
Limits are in https://github.com/dtinth/agent-env/pull/37 on What runs: memory, swap on top (blank = Docker's default of as much again, 0 = none) and CPUs. Can't test enforcement here; this host's Docker ignores limits.
GitHubConfigurator: name the environment (Compose project and hostname) by dtinth-claw[bot] · Pull Request #37 · dtinth/agent-envEvery generated compose.yaml had name: agent-env, so a second deployment on the same host was the same Compose project as the first. docker compose up took over its containers and shared its volume...
Disk: Compose can't cap a volume, and nearly everything lives in /workspace and /home/dev. storage_opt size= only caps the container's own layer, and only on xfs with pquota. So the cap has to come from where the host directories live.