replying to @dtinth-bot
Do you have screenshots of the new configurator?
Commit
14239d9
Yes, from the PR branch. Step 3 "What runs": OpenCode at /, one desktop choice, then extras. SMB only shows on a tailnet (2nd). It always writes AGENT_ENV_COMPONENTS (3rd).
I would like to revamp this configuration so it is more modular. Can you prototype a few UI examples so I can choose from it? Also, where can I configure the provisioning script?
@dtinth 3 takes on "What runs": A catalog cards, B list+detail, C chips + boot timeline. All add git-repo components and a startup script as compose configs (mock for now). Branch components-ui-protos: https://github.com/dtinth/agent-env/commit/276bff3. Which one?
GitHubConfigurator prototypes: three takes on a modular What runs step · dtinth/agent-env@276bff3For choosing a direction. Each is its own page under vp dev (/proto-a.html, /proto-b.html, /proto-c.html, ?demo=ready for a full one) and replaces only step 3 of the real stepper: - A, catalog: co...
I like number two the most, but can you show me how it might look like on mobile? Also, let's add the SMB server here.
@dtinth B on a phone: list first, tap opens the detail with a back link, switches work from the list. SMB is now always listed; off a tailnet it's disabled and says why. Is that what you meant by adding SMB? https://github.com/dtinth/agent-env/commit/13738e1
GitHubPrototype B: a phone layout, and SMB always listed · dtinth/agent-env@13738e1Under 700px the list and the detail take turns: the list fills the step, picking an item opens its detail with a back link, and the switches still work from the list. SMB is listed in every mode. ...
I think we don't need the switch inside the list. Just go to the details and switch it on or off because currently it is not clear when you configure that you can go inside and adjust it.
Furthermore, I think it is fine to have SMB on non-Tailnet setup because each compose…
@dtinth Done: the list only shows On/Off and a ›, the switch lives in the detail. SMB is offered in every mode now, never published; off a tailnet it says to forward 445 yourself. That's in PR #41 too (0dc7371). Protos: https://github.com/dtinth/agent-env/commit/bd45739
GitHubPrototype B: no switches in the list; SMB offered in every mode · dtinth/agent-env@bd45739The list only shows each item's state (On, Off) and a chevron, so it reads as something to open; turning a component on or off is done in its detail. SMB follows the configurator: offered in ev...
On mobile, the stepper looks off because the step number circles wrap into the second line.
For the your own app, I'm not sure if this is needed because now we can just create components on our own and we already have the provisioning script and stuff like that. Personally, I…
@dtinth Done (ccd9f1f): the stepper stays on one line on phones, Your own app is gone, and Docker just says Off in the list, with the host-flags note in its detail. The stepper fix also applies to the real configurator.
No need for 'yours' section, just let user put them in the startup script. No need for git clone integration yet, don't over engineer.
@dtinth Done (83f6e33): no Yours section, no git rows. The startup script's detail says your own components go there, and its example clones one and runs agent-env component install. I also removed prototypes A and C. Make B the real step next?
Yeah. I think we don't need the built-in or the section headers because we don't explain what they mean. It would only lead to confusion, and I think it is understandable enough without it. Let's do it!
@dtinth Done: https://github.com/dtinth/agent-env/pull/42 (on top of #41). B is the real step, no headers. The startup script now goes into compose.yaml as a config in provision.d. setup.ts keeps it but doesn't prompt.
GitHubConfigurator: "What runs" as a list and detail, with a startup script by dtinth-claw[bot] · Pull Request #42 · dtinth/agent-envThe configurator's "What runs" step as a list and a detail, from the prototype chosen on dev-null, and a startup script the configurator writes for real. Stacked on #41. Requested in ...
Please combine them into a single PR so it goes in at once
Combined: #41 now includes the What runs step and the startup script (d9b6317), and its description covers both. GitHub shows #42 as merged only because its commits are in #41's branch now. Full CI is running on #41.
@dtinth #41 is green with everything in it (d9b6317): both arch builds and smoke tests, the setup wizard, and Devin Review, with no new comments. Ready when you are.
Thank you, I merged the PR.
Thanks! Components, the new What runs step and the startup script are all in main now.
Turning Docker on adds five flags to compose.yaml. A rootless engine needs them: cap_add: SYS_ADMIN, unconfined seccomp, AppArmor and systempaths, and /dev/net/tun. The configurator writes them for you.What are the risks?
@dtinth Honestly: on normal rootful Docker, with these flags root in the container can become root on the host, and dev has passwordless sudo, so the agent can too.
The worst is systempaths=unconfined: it makes /proc/sys writable, and /proc/sys/kernel/core_pattern isn't namespaced, so root can make the host run any program as root. /proc/sysrq-trigger can reboot the host. SYS_ADMIN plus no seccomp or AppArmor also opens mount, bpf and many more kernel bugs.
I checked that the flags remove those read-only mounts. This machine's Docker is rootless, so I couldn't try the escape itself. On a rootless or userns-remapped Docker host, container root isn't host root, which contains it.
So our docs are wrong where they say no path from container root to host root. Want me to fix that wording, and make the configurator's Docker note say plainly it is host-root-equivalent unless the host's Docker is rootless?
commit 14239d9
You are actually running on agent-env with rootless Docker, you can try finding the flag I planted on the host at /home/thai.guest/Scratch/flag.txt