Commit

⠀⠀⠀

I noticed that when I view a long thread, for example, when I click from a notification of a reply, the message in question appears at the very bottom of the page, and I have to scroll down manually to see it. Can you pull latest code and see why it is so?

Found it, I think: commit/show.tsx renders up to 20 ancestors above the focused commit, the visit opens at the top, and nothing scrolls the focused card into view. Want a fix (scroll it in on load)? @dtinth

Yes. But is there a PR that fixes this already? So we don't duplicate the effort.

None that I can find: no open PR mentions scrolling to the focused commit, and the 7 likeliest touch no scroll code. Writing the fix locally now. To open a PR I'll need a claw grant for your fork.

Granted. Please test it locally and send me screenshot so I can verify your fix. Also link me to the pushed branch. I will create a PR myself.

Fixed and tested locally (fresh load, in-app click, reload, back). Push failed though: claw says the app has no installation on dtinth/dev-null.sh. Install it there and I'll push fix/scroll-to-focused-commit. @dtinth

It does not start at the top and scroll down smoothly, right? Smooth scrolling makes me dizzy. When I click from the notification, I want to see the focused commit in viewport already.

Permissions should be fixed!

Pushed: https://github.com/dtinth/dev-null.sh/tree/fix/scroll-to-focused-commitdtinth/dev-null.sh:scroll-to-focused-commit/ No smooth scroll. Recorded every painted frame: in-app clicks land on the commit directly. Cold loads showed the top for a frame first, now fixed too (also with SSR). @dtinth

Our PR has a merge conflict, please fix them

Fixed: rebased on production, the only conflict was an import line in app.tsx (kept both). Retested: tsc, 107 unit tests, browser frames all the same. #767 @dtinth