/dev/null
Sign in

Commit

ee40c59

dtinth’s bot@dtinth-bot
replying to @dtinth
Q1, the root: what is a "component"? Today there are 7 *_ENABLE flags hard-wired in the entrypoint, while a preset is a self-contained dir it knows nothing about. I recommend components use the preset shape: rootfs/opt/agent-env/components/<name>/ with tools.toml, a daemon…
Thai Pangsakulyanont@dtinth
Definitely in the same image, yes. However users should be able to add their own components in case they want to run something else too, without having to build their own image.
dtinth’s bot@dtinth-bot
Q2, where user components live and what they may run as. A built-in one may need root (sshd, the desktop, rootless dockerd). A user one is just files in a volume. I recommend user components live in ~/.config/agent-env/components/<name>/, the same shape as built-ins, on the home…
dtinth’s bot@dtinth-bot
Almost everything. Looking at what runs here: Must stay root (the core, not components): - sshd: it logs you in as dev - the gateway (caddy + oauth2-proxy as gateway): an edge hole must not land in the account with sudo, and dev's code must not read its secrets - the…
Thai Pangsakulyanont@dtinth
Agree. Please look at all the core and components. What are the common things it need to do? For example, I might want to set up a daemon that runs whenever this container runs. I would have to configure pitchfork myself, etc. So I am thinking of something more convention-based.…
dtinth’s bot@dtinth-bot
Surveyed everything. The glue every piece repeats: 1. an enable flag 2. a daemon (user pitchfork), with readiness (port/cmd/http) and sometimes depends 3. a loopback run script reading env with defaults 4. a gateway route under /~env/<name>, prefix stripped or passed through 5.…
Thai Pangsakulyanont@dtinth
- I wonder if we can get rid of the preset and make it also a component. - component.env - how about toml? - run - I think this can link to a folder with pitchfork.toml so we can run pitchfork on it. - I don't like the *_ENABLED env. Maybe better to have it not run in the…
dtinth’s bot@dtinth-bot
1. Presets as components: yes. opencode becomes a component that claims / . vanilla is simply "nothing claims /". PRIMARY_COMMAND becomes a tiny built-in component. One rule: at most one component may claim / . 2. TOML: yes, component.toml. 3. pitchfork.toml in the folder:…
Thai Pangsakulyanont@dtinth
Sounds good. It should support symlinking. agent-env-component.toml? I think we should also have some kind of support for startup script or hook which runs before we start user-level pitchfork. Then this would let me write script that provision. I would put it in a compose…
dtinth’s bot@dtinth-bot
Good. agent-env-component.toml it is: distinctive, so a repo root can be a component by itself. Symlinks: work, with one catch I just tested. pitchfork names daemons after the link's target, so components/smb -> ~/src/my-repo shows up as my-repo/web. pitchfork.toml has a…
Thai Pangsakulyanont@dtinth
Agree. Also want an easy way to install a component, so maybe agent-env component install . which idempotently creates a symlink. Name is defined in toml and it refuses to replace a symlink if already installed but points to different folder unless --force? It should lint stuff…
dtinth’s bot@dtinth-bot
Agree on all of it: - agent-env component install . reads the name from agent-env-component.toml and symlinks ~/.config/agent-env/components/<name>. It's a no-op if the link already points here, refuses if it points elsewhere unless --force. Plus uninstall <name> and list.…
Thai Pangsakulyanont@dtinth
Agree. The host is good. For mise tools, on reconcile, it would symlink the tool to conf.d right? e.g. conf.d/agent-env-<name>.toml. And also deletes the ones not listed?
dtinth’s bot@dtinth-bot
Yes, symlink rather than copy (today it copies), so editing a component's mise.toml applies on the next mise install. Tested: mise reads a conf.d symlink pointing outside ~/.config with no trust prompt, [env] included. Deleting: the reconciler owns every…
Thai Pangsakulyanont@dtinth
Looks good. Why we need agent-env opencode in the first place? What is it for, like what are its use cases? No need to keep backwards compatibility tho. Btw just noting, before you start the implementation I want you to make a docs describing the component system. Then, have a…
dtinth’s bot@dtinth-bot
Good question. Looking at them, there's not much case for it: - agent-env tui cds to the workspace, waits for the server and runs opencode --server .... But env.sh already sets OPENCODE_SERVER and its password in login shells, so plain opencode attaches to the same server.…
dtinth’s bot@dtinth-bot
We could. Links into ~/.local/bin win on two points: - Instant: ~/.local/bin is already on PATH everywhere (login shells, ssh box cmd, daemons, open terminals). A new PATH entry only reaches shells and daemons started after install, and /etc/environment would need rewriting as root. - Clashes are visible: with PATH order, two components shipping foo means one silently shadows the other. Links let install refuse. Cost: stale links to clean up, but the reconciler already does that for conf.d. I'd still go with links. Your call.

commit ee40c59

TP
Thai Pangsakulyanont
How about ~/.agent-env/bin in PATH? By the way, for the sub-agent review, I want it to also flag the implementation details they did not need to know so the docs is user facing. Another question is what language would you use to implement these commands? Python?